-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail prerendering if page attempts to access session
in load
- fixes #3722
#4811
Merged
Rich-Harris
merged 8 commits into
sveltejs:master
from
elliott-with-the-longest-name-on-github:sejohnson-fail-prerender-on-session-access
May 23, 2022
Merged
Fail prerendering if page attempts to access session
in load
- fixes #3722
#4811
Rich-Harris
merged 8 commits into
sveltejs:master
from
elliott-with-the-longest-name-on-github:sejohnson-fail-prerender-on-session-access
May 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🦋 Changeset detectedLatest commit: ad3d599 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hmm. Strange. I linted/checked locally... I'll run again and push if necessary. |
Rich-Harris
approved these changes
May 23, 2022
excellent, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to prerender a page that tries to access
session
, as it can never be populated by the server. Similarly to how we throw if we try to prerender a page that has a mutative shadow endpoint, we now throw if a page tries to accesssession
during prerendering. This exception can be skipped by settingcontinueOnError
totrue
, but it will still warn users by logging the error to the console. Fixes #3722.As is, this will fail on server-side requests while in dev as well (so that developers don't have to wait until they try to build for prod to get slapped in the face with it).
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0