Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robustify error handling #5108

Merged
merged 4 commits into from
May 30, 2022
Merged

robustify error handling #5108

merged 4 commits into from
May 30, 2022

Conversation

Rich-Harris
Copy link
Member

Currently, if you introduce an error into a component that causes rendering to fail...

<p>{this_variable_does_not_exist}</p>

...fixing the component won't cause the page to recover, because Svelte itself is now in a broken state. (We plan to make Svelte more resilient to this sort of thing, but it's a ways off.) Adding hot.optimistic: false to the vite-plugin-svelte options causes the page to reload on HMR updates after a rendering error is encountered.

That solves half the problem. If the page reloads and it's still broken, the server will render an error page. Since the error page generally won't use the component where the error was, subsequent HMR updates will be ignored, so fixing the component won't cause the error page to go away.

I think a reasonable way to fix that is to always reload the page when an HMR update occurs, if you're on an error page.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 29, 2022

🦋 Changeset detected

Latest commit: 9d66370

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann requested review from dominikg and rixo May 29, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants