Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add redirects for routes containing '__data.json' suffix #5180

Merged
merged 5 commits into from
Jun 22, 2022
Merged

fix: add redirects for routes containing '__data.json' suffix #5180

merged 5 commits into from
Jun 22, 2022

Conversation

ericapisani
Copy link
Contributor

@ericapisani ericapisani commented Jun 7, 2022

Fixes #4872

We also needed to await the builder.createEntries call as it was not completing before the redirects array was being written to the build/redirects file.

Demo of site before fix: https://627c046d20bc620009be8eef--test-ssr-split.netlify.app/endpoint
Demo of site after fix: https://ep-svelte.netlify.app/

Way to reproduce/confirm fix

  • Visit one of the above links
  • Visit either 'endpoints' or 'todos' page

Before:

  • Would see a 404 on both pages
  • Refreshing on 'endpoints' page would render the page correctly, but not on todos
  • Checking the network tab when navigating to todos through client side navigation showed that the route for todos/__data.json (and the related one for endpoints) was returning a 404

After:

  • Correct page will render, both in client side navigation and when refreshing on the page itself

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022

🦋 Changeset detected

Latest commit: 74d63c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ericapisani ericapisani changed the title fix: add redirect for routes containing '__data.json' suffix fix: add redirects for routes containing '__data.json' suffix Jun 7, 2022
Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @erica. Looks great!

@Rich-Harris
Copy link
Member

excellent, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In adapter-netlify split:true config is breaking SSR and other things.
3 participants