(fix) missing-custom-element-compile-options cannot be ignored

#409
sveltejs · Aug 5, 2020 · c8b1950 · c8b1950
1 parent d48fa0f
commit c8b1950
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/packages/language-server/src/plugins/svelte/features/getCodeActions/getQuickfixes.ts b/packages/language-server/src/plugins/svelte/features/getCodeActions/getQuickfixes.ts
@@ -67,10 +67,20 @@ function getCodeActionTitle(diagnostic: Diagnostic) {
     return `(svelte) Disable ${diagnostic.code} for this line`;
 }
 
+/**
+ * Whether or not the given diagnostic can be ignored via a
+ * <!-- svelte-ignore <code> -->
+ */
 export function isIgnorableSvelteDiagnostic(diagnostic: Diagnostic) {
     const { source, severity, code } = diagnostic;
-    return code && source === 'svelte' && severity !== DiagnosticSeverity.Error;
+    return (
+        code &&
+        !nonIgnorableWarnings.includes(<string>code) &&
+        source === 'svelte' &&
+        severity !== DiagnosticSeverity.Error
+    );
 }
+const nonIgnorableWarnings = ['missing-custom-element-compile-options'];
 
 async function getSvelteIgnoreEdit(svelteDoc: SvelteDocument, ast: Ast, diagnostic: Diagnostic) {
     const {