Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte-ignore not respected for custom element tags #409

Closed
milkbump opened this issue Aug 1, 2020 · 1 comment
Closed

svelte-ignore not respected for custom element tags #409

milkbump opened this issue Aug 1, 2020 · 1 comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.

Comments

@milkbump
Copy link

milkbump commented Aug 1, 2020

Describe the bug
svelte-ignore warning is not ignored in VS Code.

To Reproduce
Steps to reproduce the behaviour:

<!-- svelte-ignore missing-custom-element-compile-options -->
<svelte:options tag="my-element"/>

Expected behaviour
The warning should not be displayed when svelte-ignore is present.

Screenshots
Screenshot 2020-08-01 at 8 54 23 pm
Screenshot 2020-08-01 at 8 54 13 pm

System (please complete the following information):

  • OS: MacOS
  • IDE: VS Code
  • Plugin/Package: Svelte for VS Code

Additional Context
Ignoring works for other warnings such as <!-- svelte-ignore a11y-missing-attribute --> on an img without an alt attribute.

@milkbump milkbump added the bug Something isn't working label Aug 1, 2020
@milkbump milkbump changed the title svelte-ignore not respect for custom element tags svelte-ignore not respected for custom element tags Aug 1, 2020
@jasonlyu123
Copy link
Member

jasonlyu123 commented Aug 1, 2020

This means svelte compiler don't allow suppressing this warning. We'll have to remov that from svelte-ignore code action. If you want it to be able to suppress it you'll have to file an issue in the main repo.

@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

3 participants