-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String content erased when inferring slot/event type from props #1113
Comments
I can't reproduce the type-check error with the example you provide. The |
You’re right. The code I posted works indeed. I assumed that I narrowed the error down to a minimal case. I’ll update the description with an example that indeed fails. |
There're two problems with this one. The empty string is used to simplify transformation. In more cases, it shouldn't matter. The reason you're only encountering it with a template literal is that its multi-line. The multi-line causes the generated code to not been ignored properly with our current approach. I fixed the empty string part (not released yet). But you might still encounter some problems with rename symbol when the identifier is referenced in the props. As the generated code is not being ignored. This one is more tricky to fix. |
The empty string part is released. You can try it again. I'll leave this open for the multi-line problem. |
The multiline problem is fixed now. |
Because of [a bug in svelte-check][1] we also replace single quotes with a proper right single quote (’). [1]: sveltejs/language-tools#1113 Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Because of [a bug in svelte-check][1] we also replace single quotes with a proper right single quote (’). [1]: sveltejs/language-tools#1113 Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Because of [a bug in svelte-check][1] we also replace single quotes with a proper right single quote (’). [1]: sveltejs/language-tools#1113 Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
Because of [a bug in svelte-check][1] we also replace single quotes with a proper right single quote (’). [1]: sveltejs/language-tools#1113 Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
The following Svelte code fails to check with
svelte-check
v2.2.3.It shows the error
The example looks artificial but this layout is produced by prettier if the expression inside
${}
is long.The text was updated successfully, but these errors were encountered: