Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) infer slot/event type from literal string type props #1121

Merged
merged 1 commit into from Jul 30, 2021

Conversation

jasonlyu123
Copy link
Member

@jasonlyu123 jasonlyu123 commented Jul 29, 2021

bringing back the string props handling in #952 but change the handling method for multiple props values to a template literal. So it can cover template literal type.

This would let the error in #1113 go away. But it would still have some problems with rename symbol. Because it's not properly ignored.

@jasonlyu123 jasonlyu123 merged commit 20ade7c into sveltejs:master Jul 30, 2021
@jasonlyu123 jasonlyu123 deleted the infer-prop-type-string branch July 30, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant