Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic autoCompletion not working Fine on VsCode #144

Closed
dolpsdw opened this issue May 30, 2020 · 4 comments · Fixed by #145
Closed

Basic autoCompletion not working Fine on VsCode #144

dolpsdw opened this issue May 30, 2020 · 4 comments · Fixed by #145
Labels
bug Something isn't working

Comments

@dolpsdw
Copy link

dolpsdw commented May 30, 2020

Describe the bug
Following tutorial on VsCode, i found autoCompletion for simple JS string not working.

To Reproduce
autoCompletion

Expected behavior
The one that happens when empty string is concatenated.

System (please complete the following information):

  • OS: Windows10
  • IDE: VSCode
  • Plugin/Package: "Svelte Beta"
@dolpsdw dolpsdw added the bug Something isn't working label May 30, 2020
dummdidumm pushed a commit to dummdidumm/language-tools that referenced this issue May 31, 2020
Mark completion list as incomplete when there are parser errors. This way, the server is asked about completions until he can give valid suggestions.

Fixes sveltejs#144
dummdidumm added a commit that referenced this issue Jun 1, 2020
Mark completion list as incomplete when there are parser errors. This way, the server is asked about completions until he can give valid suggestions.

Fixes #144
@dolpsdw
Copy link
Author

dolpsdw commented Jun 1, 2020

Not sure if this is closable.
The new behavoir still not the wanted.

As developer (specialy one new on Svelte)
I want to be able to learn by inspecting with "intellisense" and being presented with real stuff.

And the toLower case Option is not suggested until src.toLow
autoCompletion2

@dummdidumm
Copy link
Member

The fix will be available in about 20 hours after the next deployment. After that it will be better but you still will need to type at least one character after the dot. This cannot be changed unless the svelte compiler gets more robust, because he will throw a syntax error. This ticket tracks it sveltejs/svelte#4818

@dolpsdw
Copy link
Author

dolpsdw commented Jun 1, 2020

Not sure if it helps, but using webStorm with https://github.com/tomblachut/svelte-intellij
The autoCompletion seems to work fine there.

Also if forced to type 1 character after the . you will never be able too see the full api object api ?
:(

@dummdidumm
Copy link
Member

Yes that's true. It's unfortunate but it will hopefully not stay like this forever.
The other extension uses a different approach. I think they don't use the svelte compiler to analyze the syntax tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants