Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #80, filtering completion trigger character #82

Merged
merged 1 commit into from
May 12, 2020
Merged

fix #80, filtering completion trigger character #82

merged 1 commit into from
May 12, 2020

Conversation

jasonlyu123
Copy link
Member

  1. getCompletions now use CompletionContext instead of just triggerCharacter
  2. TS and CSS now only allow specific trigger characters and will not try to get global completion if completion is invoked by a trigger character in which specified in server capability(

    language-tools/packages/language-server/src/server.ts

    Line 51 in 4a8bdd7

    triggerCharacters: [
    )

@dummdidumm
Copy link
Member

Great job!

@dummdidumm dummdidumm merged commit 83d2213 into sveltejs:master May 12, 2020
@dummdidumm dummdidumm mentioned this pull request May 12, 2020
Open
@jasonlyu123 jasonlyu123 deleted the fix-completion branch June 20, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonlyu123 @dummdidumm