(perf) Optimize fallback watcher #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the reasons for problem #950 and sublimelsp/LSP-svelte#44 encountering is devastating is that the chokidar would trigger an initial event. That causes all the js/ts files to be scanned on startup. Rather than only in
npm ias I originally thought.Even if we are excluding node_modules now. This behavior still needs to be disabled. So we can save all those IO operations on startup. And delay the language service creation when not needed.
Another change is to denounce the watch file callback. Squashing multiple changes into one. This means fewer update project files call when switching branches or when generated files are written to the file system.