fix excluded file got added to snapshot manager #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Rereading this, I think I introduced this bug about one month ago while refactoring the SnapshotManager. I changed the behavior back then to create new snapshots if one doesn't exist already. This should fix it. |
|
Part of it also my fault. The intention of the original code is not very clear 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the underlying problem for #950 and sublimelsp/LSP-svelte#44. The files are added into snapshot manager no matter if it's updated or added. This caused memory to blow up alongside the problem of the fallback watcher. The fallback watcher is not the actual problem.