Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Remove hard coded production build from sapper build command #241

Closed
johanalkstal opened this issue Apr 18, 2018 · 0 comments · Fixed by #249
Closed

Remove hard coded production build from sapper build command #241

johanalkstal opened this issue Apr 18, 2018 · 0 comments · Fixed by #249

Comments

@johanalkstal
Copy link

sapper build is hard coded to set NODE_ENV to production.

This makes it impossible to do atleast two things,

  1. Deploy an unoptimized/minified build of the application
  2. Use the webpack config files to configure settings for different environments (using dotenv or Webpack.DefinePlugin or similar text replace tools) because process.env.NODE_ENV within the webpack files is always production.

I think a reasonable change is to have sapper build use whatever NODE_ENV is set to and if it doesn't exist, use production by default?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant