Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Routes are not ignoring .DS_Store files and build breaks #252

Closed
arxpoetica opened this issue May 4, 2018 · 4 comments
Closed

Routes are not ignoring .DS_Store files and build breaks #252

arxpoetica opened this issue May 4, 2018 · 4 comments

Comments

@arxpoetica
Copy link
Member

Sneer: why, Apple. Why.

This change 93128a0 introduced the problem. The build breaks when those sometimes autogenerated Apple files appear. I'm wondering what other . files will cause problems?

@Rich-Harris
Copy link
Member

Proposed fix: exclude files without an extension. I can't think of any common dotfiles that have one, and all your route files will have one (whether .js, .html, .ts or something else).

Would be an easy PR if anyone wants to take it one — src here, tests here

@silentworks
Copy link
Contributor

silentworks commented May 4, 2018

@Rich-Harris that would break .well-known, wasn't this the reason this was introduced in the first place?

#243

@akihikodaki
Copy link
Contributor

I searched the Internet for information about .DS_Store issue (because I'm not a macOS user.) I agree ignoring files with . prefix is the best solution.
#254 ignores those files except .well-known, which #243 allowed to implement as @silentworks points out.

@arxpoetica
Copy link
Member Author

arxpoetica commented May 4, 2018

@Rich-Harris good on ya' for pointing us in the way to fix it instead of just doing it. ;)

If you keep up that pattern, I'll definitely try and jump in the game more.

...teach someone to fish...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants