Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

goto should return Promise #270

Closed
tevel opened this issue May 17, 2018 · 5 comments · Fixed by #299
Closed

goto should return Promise #270

tevel opened this issue May 17, 2018 · 5 comments · Fixed by #299

Comments

@tevel
Copy link

tevel commented May 17, 2018

It seems like there is no way to navigate page and get notified when it done.

It would be great if sapper/runtime.js/goto will return promise as it done in other frameworks (e.g. angular2.router.navigate())
@tevel
Copy link
Author

tevel commented May 17, 2018 •
edited
Loading

my use case: navigate to the page, wait until it finished and then scroll down

@silentworks
Copy link
Contributor

I had a chat with @Rich-Harris on gitter and he said that this should change to return a Promise, if you want, you can create a PR for it or someone will get to it at some point.

@tevel
Copy link
Author

tevel commented Jun 1, 2018

create what? what is PR?

@silentworks
Copy link
Contributor

A Pull Request (PR).

Rich-Harris added a commit that referenced this issue Jun 27, 2018
@Rich-Harris
return a Promise from goto - fixes #270
57eeb56
@Rich-Harris Rich-Harris mentioned this issue Jun 27, 2018
Merged
Rich-Harris added a commit that referenced this issue Jun 28, 2018
@Rich-Harris
Merge pull request #299 from sveltejs/gh-270
e9a7177 
return a Promise from goto
@Rich-Harris
Copy link
Member

fixed in 0.14 — thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

return a Promise from goto sveltejs/sapper
3 participants
@silentworks @Rich-Harris @tevel