Decode req.params

[Rich-Harris]

Another thing thrown up by the surprisingly productive issue #347: we should probably apply decodeURIComponent to req.params. That's what Express does if you have something like this:

app.get('/blog/:slug', (req, res, next) => {
  // req.params.slug is decoded
});

I think it's what I'd expect to happen in any case.

[mrkishi]

Sapper should probably decode req.query keys and values as well -- and also replace + with ' ' in these.

[Conduitry]

(I haven't checked any code or behavior before writing this comment, but) Wouldn't the underlying Express/Polka/etc. library be responsible for decoding req.query?

[mrkishi]

I meant the client-side routing part.

But you bring a good point: currently, server-side rendered components receive the framework's req.query, so I believe that yeah, we really should match that behavior in the client-side router.

[lukeed]

Express & Polka both use parseurl which immediately passes off the request to url.parse as soon as there's a query involved, as well as a few other characters, which i know decodes the path. Polka passes off any query key from that result into querystring.parse which I'm 95% sure decodes.

[Rich-Harris]

I've updated the PR so that req.query is consistent between client and server. I hadn't come across the + thing before, interesting

[mylastore]

does anyone knows if express-validation can some how be added? Is there any discussion forums for svelte or sapper?