Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Prefix file paths in SW manifest with a slash #1244

Merged
merged 2 commits into from Aug 6, 2020

Conversation

0xd61
Copy link
Contributor

@0xd61 0xd61 commented May 28, 2020

This PR adds a "/" to the file paths in the SW manifest file during compile time.
Fixes #1210

@benmccann
Copy link
Member

@antony should we apply the "breaking change" label to this one?

@antony
Copy link
Member

antony commented Jun 30, 2020

@benmccann why do you consider this breaking?

@benmccann
Copy link
Member

For folks that already updated their service worker to match the existing paths, this change would break their caching. I think it's rare that folks have fixed their apps because I see broken apps in the wild all the time, so this change would fix the majority of apps and probably only a small minority would need to revert their service workers to match this change. But it's worth calling out in the changelog as a breaking change so folks can check and be aware if they previously updated their service worker to deal with this issue that they'll need to update it again

@antony antony added the breaking Breaking Changes label Jul 14, 2020
@antony antony added this to the 0.28 milestone Jul 30, 2020
@benmccann benmccann requested a review from antony July 31, 2020 22:20
@lukeed
Copy link
Member

lukeed commented Aug 5, 2020

Breaking something by fixing it is probably the best kind of break, haha. Would also mean any workaround for anything has to be considered before patching.

Copy link
Member

@antony antony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, sorry it took so long to review!

@benmccann benmccann merged commit 9e12fb0 into sveltejs:master Aug 6, 2020
@0xd61 0xd61 deleted the add_slash_to_files_for_sw branch August 7, 2020 11:06
trmcnvn pushed a commit to metafy-gg/sapper that referenced this pull request Aug 15, 2020
benmccann added a commit to benmccann/sapper that referenced this pull request Jan 4, 2021
benmccann added a commit to benmccann/sapper that referenced this pull request Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SW not serving precached files
4 participants