This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Upgrade chokidar disable globbing issue 212 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 3, 2018 12:49
Rich-Harris
reviewed
Apr 3, 2018
src/cli/dev.ts
Outdated
| @@ -311,7 +311,8 @@ function watch_files(pattern: string, events: string[], callback: () => void) { | |||
|
|
|||
| const watcher = chokidar.watch(pattern, { | |||
| persistent: true, | |||
| ignoreInitial: true | |||
| ignoreInitial: true, | |||
| disableGlobing: true | |||
There was a problem hiding this comment.
should this be disableGlobbing?
|
Thanks — am slightly curious about how this works, don't we need globbing? One of the patterns we're using is |
|
Uh, yes it should be |
|
Please see this issue discussion paulmillr/chokidar#699 |
|
thanks — publishing 0.10.4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #212