This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Don't try to crawl hundreds of pages simultaneously #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikarigeorge
reviewed
Oct 16, 2018
src/api/export.ts
Outdated
| @@ -140,11 +144,13 @@ async function execute(emitter: EventEmitter, { | |||
|
|
|||
| if (href) { | |||
| const url = new URL(href, base.href); | |||
| if (url.origin === origin) urls.push(url); | |||
There was a problem hiding this comment.
Hi, I think the urls declaration is not needed anymore in line 127
There was a problem hiding this comment.
good catch, thanks — removed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could maybe tweak this to make it a global queue, but this is probably fine for any realistic website