This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Explicitly load style-loader/css-loader deps #72
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to fix sveltejs/sapper-template#27
|
Hm, on second thought, this appears to fix the console errors but doesn't actually enable async style loading. I have some style in a subcomponent that isn't loaded when it's loaded asynchronously... this needs more investigation. |
|
Nevermind, that other issue appears to be unrelated. I'll try to find a repro. In any case, this PR allows the app to actually load subpages, which is a more serious bug than not being able to load async styles. |
|
Opened a separate issue, and it is indeed a separate issue: #79 |
|
Thank you! Top sleuthing, not sure I would ever have figured that out. Seems a bit unfortunate, will have to see if there's a way around the extra bytes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix sveltejs/sapper-template#27. It's based on the proposed workaround in webpack-contrib/extract-text-webpack-plugin#456 (comment)
The downside is that the production size of
main.jsappears to increase from 4.2KB to 6.2KB. On the other hand... async style loading actually works. 😅 I don't see any more console errors while clicking around in the production app.