Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some await bugs #1061

Closed
dxlbnl opened this issue Dec 31, 2017 · 1 comment
Closed

Some await bugs #1061

dxlbnl opened this issue Dec 31, 2017 · 1 comment
Labels
bug

Comments

@dxlbnl
Copy link
Contributor

dxlbnl commented Dec 31, 2017

I've encountered some bugs with the new and fresh Await block.
There's a repl here.

  • First of a minor issue, the Components used in the await block don't get registered as 'used', so a warning is incorrectly shown
  • Then it appears a subcomponent in the await block won't call oncreate
  • In another situation it does call oncreate (unsure how/why), but it's called in a state where the component isn't mounted yet (I notice this using refs, and them being undefined in a situation where I'm using await, and a working situation when I don't)
@arxpoetica arxpoetica added the bug label Jan 5, 2018
@arxpoetica arxpoetica added this to Triage in Roadmap Jan 10, 2018
@arxpoetica arxpoetica moved this from Triage to Immediate priorities in Roadmap Jan 10, 2018
Rich-Harris added a commit that referenced this issue Jan 11, 2018
@Rich-Harris
validate contents of await blocks (#1061)
5fea63a
@Rich-Harris Rich-Harris mentioned this issue Jan 11, 2018
Merged
Rich-Harris added a commit that referenced this issue Jan 11, 2018
@Rich-Harris
fire oncreate handlers for components inside await blocks (#1061)
c1b5bed
@Rich-Harris Rich-Harris mentioned this issue Jan 11, 2018
Merged
@Rich-Harris Rich-Harris moved this from Immediate priorities to PR'd in Roadmap Jan 11, 2018
Rich-Harris added a commit that referenced this issue Jan 11, 2018
@Rich-Harris
Merge pull request #1093 from sveltejs/gh-1061-a
2537db9 
validate contents of await blocks
Rich-Harris added a commit that referenced this issue Jan 13, 2018
@Rich-Harris
Merge pull request #1094 from sveltejs/gh-1061-b
49bc092 
fire oncreate handlers for components inside await blocks
@Conduitry Conduitry removed this from PR'd in Roadmap Jan 18, 2018
@arxpoetica arxpoetica added this to Triage in Roadmap Jan 19, 2018
@Rich-Harris
Copy link
Member

These are fixed in 1.52 — thanks

@Conduitry Conduitry removed this from Triage in Roadmap Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arxpoetica @Rich-Harris @dxlbnl