validate contents of await blocks #1093
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
+ Coverage 91.53% 91.54% +<.01%
==========================================
Files 123 123
Lines 4477 4481 +4
Branches 1443 1444 +1
==========================================
+ Hits 4098 4102 +4
Misses 162 162
Partials 217 217
Continue to review full report at Codecov.
|
| @@ -54,6 +54,12 @@ export default function validateHtml(validator: Validator, html: Node) { | |||
| if (node.else) { | |||
| visit(node.else); | |||
| } | |||
|
|
|||
| if (node.type === 'AwaitBlock') { | |||
There was a problem hiding this comment.
What happens if the await block is missing one of these sections? Would visit get called with undefined? It looks like that would throw an exception.
There was a problem hiding this comment.
That's never the case — see https://github.com/sveltejs/svelte/blob/master/src/parse/state/mustache.ts#L203-L229. If we changed how that worked in future, the tests would fail, so we'd be able to add guards at that point.
fixes the easiest part of #1061