Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_store_value doesn't account for RxJS observables #3153

Closed
Conduitry opened this issue Jul 2, 2019 · 1 comment · Fixed by #3170
Closed

get_store_value doesn't account for RxJS observables #3153

Conduitry opened this issue Jul 2, 2019 · 1 comment · Fixed by #3170
Labels

Comments

@Conduitry
Copy link
Member

Somewhat adjacent to sveltejs/sapper#781 but I think there's other stuff going on there too.

The support we added for RxJS observables (i.e., allowing for the .subscribe() method to also return an object with an .unsubscribe() method) does not look like it extended to get_store_value.

@Conduitry Conduitry added the bug label Jul 2, 2019
@bvl12
Copy link

bvl12 commented Jul 2, 2019

Here is a minimal repl that demonstrates the bug I was discussing in sveltejs/sapper#781. https://svelte.dev/repl/8bf28363bde34ecb8fa4e9b91a9e397a?version=3.6.3

(I had misdiagnosed the problem earlier and it didn't deal with sapper, so I have closed it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants