handle rxjs-style observables with get_store_value #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rich-Harris
commented
Jul 3, 2019
| export function get_store_value<T>(store: Readable<T>): T | undefined { | ||
| let value; | ||
| store.subscribe(_ => value = _)(); | ||
| const unsubscribe: any = store.subscribe(_ => value = _); |
There was a problem hiding this comment.
I couldn't figure out how to do this properly in TypeScript, hence any
|
Even after this fix, svelte still has a problem unsubscribing from rxjs observables. Any idea what this problem could be? Minimal repl: https://svelte.dev/repl/8bf28363bde34ecb8fa4e9b91a9e397a?version=3.6.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3153