-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axe accessibility issues on Svelte docs #5678
Comments
I'd love to work on a PR for this, if that's okay. |
@geoffrich Feel free - the better accessible the docs are, the... better |
With the syntax highlighting PR merged, the color contrast violation count is down to 228 from 2018. |
Most of the remaining color contrast violations are on links. I opened a corresponding issue in site-kit since that's where the styles are coming from. Not sure who would be involved in choosing or updating a core theme color like that. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'll go ahead and close this since svelte.dev will be migrating to SvelteKit soon. If still relevant, I'll re-create the issue in the sites repo. |
Describe the bug
When running the axe accessibility checker on the docs, it identifies multiple accessibility issues:
aria-hidden=""
instead ofaria-hidden="true"
.h5
elements on the page after anh3
. These should likely beh4
instead.aside
element, which should not be placed withinmain
. We might not needaside
at all -- this element could just be a labeledul
.h1
element.To Reproduce
Expected behavior
There should be 0 Axe violations.
Severity
These issues make navigating the docs when using a screen reader more difficult. The Svelte tutorial calls out how it helps you write accessible markup -- we should set a good example by holding the docs to a high accessibility standard.
Additional context
I know this is quite a few issues in one 😅. We could split this into multiple issues if desired. However, some are closely related (e.g. everything to do with the permalinks) and some are small fixes.
The text was updated successfully, but these errors were encountered: