Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site a11y: make permalinks accessible #5877

Closed
wants to merge 1 commit into from

Conversation

geoffrich
Copy link
Member

Resolves multiple Axe accessibility violations (#5678) on the Svelte docs related to permalinks:

To fix this, I removed aria-hidden from the permalinks and added visually hidden text to indicate the purpose of the link. These changes are in a new Permalink component within site-kit and requires that change to be merged first (sveltejs/site-kit#35).

@benmccann benmccann marked this pull request as draft January 18, 2021 05:33
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I marked this as a draft for now, but we can switch back as ready to review when there's a version of sitekit with sveltejs/site-kit#35 merged

update: that PR was closed in favor of a PR in the sites repo, which means this PR should probably be against the sites repo as well once we move svelte.dev there. I'll leave this open for now as a reminder

@benmccann
Copy link
Member

@geoffrich svelte.dev has finally been migrate to the sites repo, so you should be able to send your PR there now: https://github.com/sveltejs/sites/tree/master/sites/svelte.dev

thanks for the wait. I'll go ahead and close this, but feel free to send a PR against the sites repo

@benmccann benmccann closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants