-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make permalinks accessible #35
Conversation
base.css
Outdated
|
||
/* visually hidden, but accessible to assistive tech */ | ||
.visually-hidden { | ||
border: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the indentation looks different here than elsewhere. it looks like you're using spaces while the existing files use tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, fixed now
components/Permalink.svelte
Outdated
@@ -0,0 +1,7 @@ | |||
<script> | |||
export let href; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spaces -> tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with latest commit
FYI, we're moving this repo to https://github.com/sveltejs/sites/tree/master/packages/site-kit. That location is currently used only for the SvelteKit docs, but we hope to eventually use it for all docs |
@benmccann sounds good -- should I re-create this PR over in that repo? |
yeah, that'd be great. And I have merge rights in that repo, so if you close this one and open a new one there I can get it merged 😉 |
Moved the PR to the new repo, so I'm closing this. |
This updates how permalinks are rendered to resolve some of the Axe violations in sveltejs/svelte#5678.
Summary of changes:
I'll be opening a separate PR for the svelte.dev site that is dependent on these changes.