Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types/compiler/preprocess/index.d.ts: locate-character dependency: missing when compiler is imported as a dependency #6622

Closed
btakita opened this issue Aug 5, 2021 · 1 comment · Fixed by #6726
Closed

types/compiler/preprocess/index.d.ts: locate-character dependency: missing when compiler is imported as a dependency #6622

btakita opened this issue Aug 5, 2021 · 1 comment · Fixed by #6726
Labels
compiler Changes relating to the compiler

Comments

@btakita
Copy link
Contributor

btakita commented Aug 5, 2021

Describe the bug

node_modules/.pnpm/svelte@3.42.1/node_modules/svelte/types/compiler/preprocess/types.d.ts(1,26): error TS2307: Cannot find module 'locate-character' or its corresponding type declarations.

locate-character is a devDependency, which is not installed when svelte is a devDependency or dependency.

Workaround: The package which has svelte as a dependency can add locate-character as a dependency.

Reproduction

Will add repo after ticket is created.

Logs

No response

System Info

System:
    OS: Linux 5.13 Arch Linux
    CPU: (16) x64 AMD Ryzen 7 5800X 8-Core Processor
    Memory: 28.71 GB / 62.72 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 16.6.0 - ~/.config/nvm/versions/node/v16.6.0/bin/node
    Yarn: 1.22.11 - /usr/bin/yarn
    npm: 7.19.1 - ~/.config/nvm/versions/node/v16.6.0/bin/npm
  Browsers:
    Brave Browser: 91.1.26.77
    Chromium: 92.0.4515.107
    Firefox: 90.0.2

Severity

annoyance
@Conduitry Conduitry added the compiler Changes relating to the compiler label Aug 24, 2021
dummdidumm added a commit that referenced this issue Sep 13, 2021
@dummdidumm
[fix] make Source type in preprocess private
efaea81 
Is only used internally, shouldn't be exposed. Fixes #6622
@dummdidumm dummdidumm mentioned this issue Sep 13, 2021
Merged
5 tasks
dummdidumm added a commit that referenced this issue Sep 15, 2021
@dummdidumm
[fix] make Source type in preprocess private (#6726)
98aefd3 
Is only used internally, shouldn't be exposed. Fixes #6622
@Conduitry
Copy link
Member

This should be fixed now in 3.42.6 - thanks @dummdidumm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler Changes relating to the compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] make Source type in preprocess private sveltejs/svelte
2 participants
@btakita @Conduitry