Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 site polish #8784

Open
12 of 20 tasks
benmccann opened this issue Jun 22, 2023 · 5 comments
Open
12 of 20 tasks

v4 site polish #8784

benmccann opened this issue Jun 22, 2023 · 5 comments
Labels
Milestone

Comments

@benmccann
Copy link
Member

benmccann commented Jun 22, 2023

Describe the bug

Potential new functionality

  • mobile "on this page" - should be collapsed by default if included
  • REPL code doesn't load until switching to output tab. could load it sooner

Reproduction

locally or vercel preview

Logs

No response

System Info

`master`

Severity

annoyance

@benmccann benmccann added this to the 4.x milestone Jun 22, 2023
@Loldator
Copy link

Loldator commented Jun 23, 2023

sveltejs/site-kit#158

sveltejs/site-kit#159

@tanhauhau
Copy link
Member

console output dark mode fixed in sveltejs/sites#517

@tanhauhau
Copy link
Member

what do you mean by the 3rd item: can't switch tabs on ... ?

looks okay to me right now

@zqianem
Copy link
Contributor

zqianem commented Jul 15, 2023

gentle ping for sveltejs/site-kit#164

@Rich-Harris Rich-Harris modified the milestones: 4.x, 5.0 Apr 1, 2024
@etainad008
Copy link
Contributor

etainad008 commented Sep 4, 2024

Hey, I am looking into "ensure text in buttons on homepage hero is vertically centered".
This problems derives from the Overpass font itself. The characters are not vertically aligned inside the font's box.
The easy fix is, of course, use padding: 0.45em 0.8em 0.25em; on the .cta class. But this breaks easily for obvious reasons.
A more sustainable fix is described here. I will try and implement it and will update on my findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants