Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add store.umd.js #1045

Merged
merged 3 commits into from
Dec 24, 2017
Merged

add store.umd.js #1045

merged 3 commits into from
Dec 24, 2017

Conversation

Rich-Harris
Copy link
Member

fixes #967

@codecov-io
Copy link

codecov-io commented Dec 24, 2017

Codecov Report

Merging #1045 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
+ Coverage   91.99%   92.01%   +0.01%     
==========================================
  Files         119      119              
  Lines        4361     4370       +9     
  Branches     1406     1408       +2     
==========================================
+ Hits         4012     4021       +9     
  Misses        148      148              
  Partials      201      201
Impacted Files Coverage Δ
src/parse/index.ts 90.21% <0%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827f76a...fa9287c. Read the comment docs.

@Conduitry
Copy link
Member

Is there some reason we want the UMD build tracked in the repo? That seems a bit odd.

@Rich-Harris
Copy link
Member Author

Oversight! Fixed — good catch, thanks

@Rich-Harris Rich-Harris merged commit 40e0440 into master Dec 24, 2017
@Rich-Harris Rich-Harris deleted the gh-967 branch December 24, 2017 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use Store server-side due to ESM
3 participants