[1083] Svelte should throw a compile time error when illegal characte… #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs are used in computed names Approach: For each property name, construct a string that defines a function and see if parsing that string with Acorn throws an exception. If it does, assemble an informative error message that states which property is invalid, the first invalid character, and the location of that character within the name. Changes to codebase: - Added new validator test "properties-computed-must-be-valid-function-names" - Added new check into src/validate/js/propValidators/computed.ts, "checkForValidIdentifiers" - this check was added to src/validate/js/utils/checkForValidIdentifiers.ts like the other checks in "computed.ts"
Codecov Report
@@ Coverage Diff @@
## master #1099 +/- ##
==========================================
+ Coverage 91.56% 91.57% +0.01%
==========================================
Files 123 124 +1
Lines 4493 4501 +8
Branches 1447 1447
==========================================
+ Hits 4114 4122 +8
Misses 162 162
Partials 217 217
Continue to review full report at Codecov.
|
|
Thank you! There were a couple of small tweaks I needed to make, and the easiest thing was to open a fresh PR on top of this one, so I've done that — closing in favour of #1106 |
|
Awesome, glad to have been able to kick things off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rs are used in computed names
Problem #1083 :
Computed property names are naively transformed into function identifiers so random-api becomes random-api(){} which is not allowed.
Approach:
For each property name, construct a string that defines a function and see if parsing that string with Acorn throws an exception.
If it does, assemble an informative error message that states which property is invalid, the first invalid character, and the location of that character within the name.
Changes to codebase:
"properties-computed-must-be-valid-function-names"
"checkForValidIdentifiers"
src/validate/js/utils/checkForValidIdentifiers.ts like the other
checks in "computed.ts"