Add YieldTag to parser and generator #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sveltejs/master: -> v1.0.7 use decodeCharacterReferences in text.js, not tag.js -> v1.0.6 upgrade magic-string, fix sourcemaps add .json extension to the ESLint config file add links to gulp/Metalsmith plugins more sourcemap stuff Convert entities of all text nodes add infrastructure for sourcemap tests Adding link to Browserify transform dont use options.filename for original code when generating magicstring bundle (#43)
* sveltejs/master: keep target and anchor inside mount method rename parent to root Fix typo in generator's contextualise; solves #46 fix onrender hook for nested widgets add a createAnchor helper various refactorings & fixes separate create from mount
Current coverage is 91.00% (diff: 100%)@@ master #112 diff @@
==========================================
Files 48 49 +1
Lines 1324 1345 +21
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1203 1224 +21
Misses 121 121
Partials 0 0
|
|
I think I now got the code generation right. |
Rich-Harris
added a commit
that referenced
this pull request
Dec 5, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for
{{yield}}I added a node type of YieldTag. So it is possible to extend the yield feature to named yields in the future.What is working:
{{#if}}{{each}}??