Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: measure elements before taking siblings out of the flow #11216

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Apr 18, 2024

This reverts #11208 and implements position fixing in a slightly more logical way that also fixes #10251. It's still not perfect, — it's possible to cause short-lived glitches if you have lots of transitions and animations rapidly interacting — but it's better than Svelte 4. We can worry about perfection another time (possibly with a redesigned primitive).

As with #11208, no test because you can't really test this stuff in JSDOM.

This also fixes #11156 and #11199, by removing animations once they have completed.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: 8276f45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris marked this pull request as draft April 18, 2024 11:20
@Rich-Harris
Copy link
Member Author

Converted to draft because I forgot to undelete the reverted changeset and add a new one - will do that when at my laptop

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants