Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: speedup hydration around input and select values #11717

Merged
merged 2 commits into from
May 22, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented May 21, 2024

closes #11693

TODOs:

  • needs to adjust the test suite to not care about SSRd value attributes anymore solved through idle_callback
  • manual smoke test that everything still works
  • double check if we can really remove this behavior for select elements as noted in the comment

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 648d08f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm trueadm marked this pull request as ready for review May 22, 2024 10:05
@trueadm
Copy link
Contributor

trueadm commented May 22, 2024

Screenshot 2024-05-22 at 11 12 57

Much better!

@trueadm trueadm merged commit c21f019 into main May 22, 2024
8 checks passed
@trueadm trueadm deleted the input-reset-speedup branch May 22, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove_input_attr_defaults function is slow during hydration
2 participants