Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore value attribute on select during SSR #11724

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented May 22, 2024

The value attribute on select elements does nothing - it does not influence the initial value (in SSR that's the job of the selected attribute on an option element), updating it does not influence the current value either. So instead of rendering it out and then removing it on hydration (which is costly because the mutation causes work) we just don't render it in SSR.

No new test/changeset because no change in behavior.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

The value attribute on select elements does nothing - it does not influence the initial value (in SSR that's the job of the `selected` attribute on an option element), updating it does not influence the current value either. Instead of rendering it out and then removing it on hydration (which is costly because the mutation causes work) we just don't render it in SSR.

No test/changeset because no change in behavior.
Copy link

changeset-bot bot commented May 22, 2024

⚠️ No Changeset found

Latest commit: 9972e3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm dummdidumm merged commit d590cd8 into main May 22, 2024
8 checks passed
@dummdidumm dummdidumm deleted the select-value-omit branch May 22, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants