Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simpler hydration of CSS custom property wrappers #11948

Merged
merged 8 commits into from
Jun 8, 2024

Conversation

Rich-Harris
Copy link
Member

As with #11773, we can simplify CSS custom property wrappers around components — we don't need to wrap the wrapper <div> in hydration comments or do any hydrate_nodes traversal, we can just use the element directly.

We can also put the element in the template, so that we don't need to create it inside the css_props helper. This simplifies the implementation and is less work.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: bb591c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@trueadm trueadm merged commit 388f210 into main Jun 8, 2024
8 checks passed
@trueadm trueadm deleted the simpler-css-props-hydration branch June 8, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants