-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simpler <svelte:element>
hydration
#11773
Conversation
🦋 Changeset detectedLatest commit: 4831a8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There's #10997 which is the more general issue about this - is this something we can apply more broadly in here aswell, or is |
I suspect the patterns will apply broadly, but there'll be enough finicky details in the implementation that it'll be a piecemeal process. Case in point — I'm working on CSS custom property wrappers as part of this PR as well, and it's proving finicky because we currently implement them in a backwards way |
Occurred to me that we can apply the ideas in #11770 piecemeal with the current approach to hydration and still see benefits.
This makes
<svelte:element>
more efficient — in SSR, it skips the opening hydration marker:As such,
hydrate_anchor
no longer needs to traverse the parent element just to populatehydrate_nodes
with a single element whose identity we already know. We do still need to keep a closing anchor, to handlethis
going from falsy back to truthy.TODO:
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint