fix: increment derived versions when updating #12047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2a9da58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
reviewed
Jun 16, 2024
trueadm
reviewed
Jun 16, 2024
| @@ -257,9 +264,10 @@ export function check_dirtiness(reaction) { | |||
| // In thise case, we need to re-attach it to the graph and mark it dirty if any of its dependencies have | |||
| // changed since. | |||
| if (version > /** @type {import('#client').Derived} */ (reaction).version) { | |||
| /** @type {import('#client').Derived} */ (reaction).version = version; | |||
| /** @type {import('#client').Derived} */ (reaction).version = increment_version(); | |||
There was a problem hiding this comment.
Why are you incrementing here? You should be matching the value otherwise you might cause additional invalidations that aren’t necessary.
There was a problem hiding this comment.
i don't think it would cause unnecessary invalidations. but yeah, we actually only need to increment in two places — in set and update_derived
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #12016 that I think is slightly simpler. AFAICT all we need to do is ensure that if a derived
adepends on another derivedb, andais reconnecting to the dependency graph, that ifbwas updated more recently thana,aalso updates.Fixes #11988
Fixes #12044
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint