Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify deriveds a tiny bit #12048

Merged
merged 5 commits into from
Jun 17, 2024
Merged

chore: simplify deriveds a tiny bit #12048

merged 5 commits into from
Jun 17, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jun 16, 2024

While wrapping my head round deriveds for the sake of #12047 I started to wonder if there were some other opportunities for simplification. Baby steps so far:

  • the return !is_equal line can just be return true, because is_equal is guaranteed to be false in the case that the dependency version is higher than the current reaction version
  • by extension, we don't need to return a boolean from update_derived, and can simplify that function slightly
  • (perhaps because of fix: increment derived versions when updating #12047) the second half of if (is_dirty && !is_unowned) appears to be unnecessary

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 16, 2024

⚠️ No Changeset found

Latest commit: e5dab40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from fix-versioning to main June 17, 2024 08:03
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - and yes you're right, the unowned check can be removed because no longer synchronize the versions, instead we just increment a global version upon updating deriveds now which handles this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants