chore: simplify deriveds a tiny bit #12048
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While wrapping my head round deriveds for the sake of #12047 I started to wonder if there were some other opportunities for simplification. Baby steps so far:
return !is_equal
line can just bereturn true
, becauseis_equal
is guaranteed to befalse
in the case that the dependency version is higher than the current reaction versionupdate_derived
, and can simplify that function slightlyif (is_dirty && !is_unowned)
appears to be unnecessaryBefore submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint