a11y: implement media-has-caption rule #4872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurdenner
force-pushed
the
a11y/implement-media-has-caption
branch
from
ddb4d69
to
954a34c
Compare
|
Overridden by #5075. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is one of the a11y checks from #820.
eslint-plugin-jsx-a11y
This rule is implemented in eslint-plugin-jsx-a11y. Reference:
eslint-plugin-jsx rule documentation
eslint-plugin-jsx rule implementation
eslint-plugin-jsx rule tests
Notes
audioandvideotags withmuted={false}are not validated because the compiler doesn't interpret them as static, soget_static_valuereturnsundefined.Therefore, I've opted for just checking if there is an attribute named
muted. The mentioned syntax is valid but it doesn't make much sense to use it though.