Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using the compiler as an ESM module #4972

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

Pierstoval
Copy link
Contributor

This PR provides a first solution to #4806, allowing the compiler to be built to ESM

rollup.config.js Outdated Show resolved Hide resolved
@Pierstoval
Copy link
Contributor Author

Good! Waiting for core team approval 👍

@afaur
Copy link

afaur commented Jul 19, 2020

Bump, I notice there are some lint errors, but if that's an issue can we let @Pierstoval know or merge this as is? (could do a fixup PR later if an issue)

@Pierstoval
Copy link
Contributor Author

I just rebased on master, let's see if these errors are still here, and if not, maybe I'll be able to fix them? 😉

@afaur
Copy link

afaur commented Jul 20, 2020

I was incorrect about the lint issues.

  • It says Unchanged files with check annotations which indicates they are not in your changes.

@antony
Copy link
Member

antony commented Jul 20, 2020

You can ignore the lint issues, they're because we added loose linting rules and tried not to break the existing collection of PRs. It's on my list to fix all of the lint issues.

Copy link
Member

@antony antony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, it publishes a completely separate mjs version of the compiler.

@benmccann benmccann merged commit cd95654 into sveltejs:master Aug 14, 2020
@Pierstoval Pierstoval deleted the deno3 branch August 18, 2020 12:07
@Pierstoval
Copy link
Contributor Author

Thanks for merging 👍

taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants