Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] run else-if reactive function on re-renders #6727

Merged
merged 1 commit into from
Sep 15, 2021
Merged

[fix] run else-if reactive function on re-renders #6727

merged 1 commit into from
Sep 15, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 14, 2021

Fixes https://svelte.dev/repl/0a0f5241e099434ea22f5776d215b6b9?version=3.42.5. The repl should explain the issue.

This change also makes it consistent with the current "without outros" code:

? b`if (${condition} == null || ${block.renderer.dirty(dependencies)}) ${condition} = !!${snippet}`
: b`if (${condition} == null) ${condition} = !!${snippet}`

Currently "with outros" code:

? b`if (${block.renderer.dirty(dependencies)}) ${condition} = !!${snippet}`
: b`if (${condition} == null) ${condition} = !!${snippet}`

Note the missing ${condition} == null check.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry Conduitry merged commit 79df74b into sveltejs:master Sep 15, 2021
@Conduitry
Copy link
Member

This is included in 3.42.6 - thank you!

@bluwy bluwy deleted the fix-if-block-outro-computed-function branch September 16, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants