-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only apply svelte-123xyz attributes where necessary #680
Merged
Merged
Changes from 16 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0cbd201
set up tests for omitted scoping attributes
Rich-Harris fae9036
only apply svelte-123xyz attributes where necessary (WIP)
Rich-Harris 72f39fd
Merge branch 'master' into gh-679
Rich-Harris ab40007
move CSS analysis into preprocess
Rich-Harris f97ac27
handle :global(...) styles
Rich-Harris d9aa3ec
more :global(...) handling
Rich-Harris 5499327
refactoring, and more :global(...) fixes
Rich-Harris f485c25
create reusable walkRules helper
Rich-Harris b72684e
handle universal selectors
Rich-Harris d2f5296
handle attribute selectors with = operator
Rich-Harris 74d15ea
handle empty attributes
Rich-Harris 3dfe92b
handle ~= attribute selector operator
Rich-Harris 45dd99d
implement all attribute selector operators
Rich-Harris 7b289e9
implement ID selectors, refactor
Rich-Harris 2ec0a85
apply css optimisations to SSR
Rich-Harris f79e901
bug fix
Rich-Harris 6f01d5f
refactor a bit, fix typing error
Rich-Harris 205bcfa
warn on unused selectors
Rich-Harris 2c9fb31
simplify tests
Rich-Harris 5f6db88
allow :global(...) selectors to have trailing modifiers
Rich-Harris 1290759
Merge branch 'gh-678' into gh-679
Rich-Harris 0c33eb4
fix tests
Rich-Harris 7a752df
fix handling of modified :global(...) selectors
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
selectors: ((nodes: Node[]) => boolean)[];
I believeedit: Although this type doesn't seem to match how it's used later.
extractSelectors
returns simplyNode[]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Have refactored it a bit so that it's a bit more TS-friendly (and possibly a bit clearer anyway) — a
Selector
class with anapply
method