Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding default for disclose version #8874

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Conversation

louisgv
Copy link
Contributor

@louisgv louisgv commented Jun 29, 2023

Description

This PR allows the built-in nodejs resolver (18.x) to lookup internal/disclose-version, otherwise it yields:

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './internal/disclose-version' is not defined by "exports" in /Users/lab/Projects/plasmo/examples/with-svelte/node_modules/svelte/package.json

The call looks like this:

const filePath = require.resolve("svelte/internal", {
        paths: [""]
})

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@gtm-nayan
Copy link
Contributor

Could you add a changeset? (run pnpm changeset at the root of the repository)

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@louisgv
Copy link
Contributor Author

louisgv commented Jun 29, 2023

Could you add a changeset? (run pnpm changeset at the root of the repository)

Running it now - will take me a bit cuz my current wifi is pretty slow

@louisgv
Copy link
Contributor Author

louisgv commented Jun 29, 2023

@gtm-nayan done

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

.changeset/proud-cycles-hunt.md Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit 270cfce into sveltejs:master Jun 29, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
@louisgv louisgv deleted the patch-1 branch June 29, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants