Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Breaking changes section #9444

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

baseballyama
Copy link
Member

@baseballyama baseballyama commented Nov 14, 2023

Related to #9437

I considered allowing event attributes by strings, but I think it was better to mark it as a breaking change because it’s easy to avoid by the following code.

<script>
  window.foo = () => console.log("hi!")
  const foo = window.foo;
</script>

<button onclick="{foo}">Hi!</button>

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 14, 2023

⚠️ No Changeset found

Latest commit: b81dac7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 14, 2023

@baseballyama is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

…breaking-changes.md

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! approved but i added a link to some docs that are added in #9449, so that needs to get merged first

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ❌ Failed (Inspect) Nov 14, 2023 11:21pm

@svelteagen
Copy link

svelteagen commented Nov 15, 2023

Related to #9437

I considered allowing event attributes by strings, but I think it was better to mark it as a breaking change because it’s easy to avoid by the following code.

<script>
  window.foo = () => console.log("hi!")
  const foo = window.foo;
</script>

<button onclick="{foo}">Hi!</button>

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Theres no way you get rid of HTML support. WTF. This sucks!

What if I don't want to do it Svelte's way?

I want HTML back!!!!!!!!!!!!!

@baseballyama
Copy link
Member Author

Maybe still we can support it via community level preprocessor.

@svelteagen
Copy link

svelteagen commented Nov 16, 2023

Maybe still we can support it via community level preprocessor.

I'm stuck with Svelte 4 unless it gets fixed. I'm not rewriting my whole app. Never did I think Svelte would do away with HTML support. That's what a lot of people love about Svelte. Don't get rid of one of Svelte's biggest strengths over other frameworks. It's why I chose Svelte. Why not just bring the feature back instead of a preprocessor? This should have never been removed from Svelte, in my opinion.

You all are acting like Svelte has never supported HTML. I thought this was a default for Svelte. I hate the new changes.

I've been using Svelte since August 2021 and never had a problem with HTML in Svelte.

Please bring this back, and not as a preprocessor. Just bring this feature back in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants