Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs #9449

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Docs #9449

merged 10 commits into from
Nov 14, 2023

Conversation

Rich-Harris
Copy link
Member

Adds docs for snippets and event attributes (TODO)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2023 •
edited

⚠️ No Changeset found

Latest commit: 50b4bc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 11:05pm

@Rich-Harris Rich-Harris mentioned this pull request Nov 14, 2023
Merged
5 tasks
dummdidumm
dummdidumm approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left a few comments, but looks good overall

sites/svelte-5-preview/src/routes/docs/content/01-api/04-event-handlers.md Outdated Show resolved Hide resolved
sites/svelte-5-preview/src/routes/docs/content/01-api/04-event-handlers.md Outdated Show resolved Hide resolved
sites/svelte-5-preview/src/routes/docs/content/01-api/03-snippets.md Show resolved Hide resolved
@Rich-Harris @dummdidumm
Apply suggestions from code review
e8d1f72 
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@Rich-Harris Rich-Harris merged commit 6bba70a into main Nov 14, 2023
8 checks passed
@Rich-Harris Rich-Harris deleted the docs branch November 14, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rich-Harris @dummdidumm