Skip to content

Commit

Permalink
chore: update pnpm 8 (#618)
Browse files Browse the repository at this point in the history
* chore: update to pnpm@8

* fix: use correct matrix vars and simplify call

* fix: remove engine restrictions for package managers

* fix: cleanup included files of internal packages to ensure pnpm@8 adds all files needed by tests

* fix: add back engines.pnpm
  • Loading branch information
dominikg committed Apr 16, 2023
1 parent 568341e commit 89ea5e8
Show file tree
Hide file tree
Showing 12 changed files with 1,478 additions and 1,565 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,17 @@ jobs:
with:
node-version: ${{ matrix.node }}
- name: install pnpm
if: matrix.node != 14
shell: bash
run: |
PNPM_VER=$(jq -r '.packageManager | if .[0:5] == "pnpm@" then .[5:] else "packageManager in package.json does not start with pnpm@\n" | halt_error(1) end' package.json)
echo installing pnpm version $PNPM_VER
npm i -g pnpm@$PNPM_VER
- name: install legacy pnpm for node14
if: matrix.node == 14
run: |
npm i -g pnpm@^7.32.0
tmppkg="$(jq '.engines.pnpm = "^7.32.0"' package.json)" && echo -E "${tmppkg}" > package.json && tmppkg=""
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
Expand Down
6 changes: 2 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,9 @@
"prettier --write"
]
},
"packageManager": "pnpm@7.30.0",
"packageManager": "pnpm@8.2.0",
"engines": {
"pnpm": "^7.13.0",
"yarn": "forbidden, use pnpm",
"npm": "forbidden, use pnpm",
"pnpm": "^8.2.0",
"node": "^14.18.0 || >= 16"
},
"pnpm": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"main": "index.cjs",
"module": "index.mjs",
"files": [
"package.json",
"index.mjs",
"index.cjs"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"name": "e2e-test-dep-cjs-only",
"main": "index.js",
"files": [
"package.json",
"index.js"
],
"type": "commonjs"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"name": "e2e-test-dep-esm-only",
"module": "esm.js",
"files": [
"package.json",
"esm.js"
],
"exports":{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"name": "e2e-test-dep-scss-only",
"main": "main.scss",
"files": [
"package.json",
"main.scss"
],
"type": "commonjs"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"main": "index.js",
"module": "index.js",
"files": [
"package.json",
"index.js"
],
"exports": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
"e2e-test-dep-cjs-only": "file:../cjs-only"
},
"type": "module",
"files": [
"src",
"index.js"
],
"exports": {
"./*": {
"svelte": "./src/components/*"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"main": "index.js",
"svelte": "index.js",
"files": [
"src",
"index.js",
"cli.js",
"package.json"
"cli.js"
],
"dependencies": {
"@types/node": "^18.15.11",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
"svelte": "src/index.js",
"main": "src/index.js",
"files": [
"src",
"package.json"
"src"
],
"exports": {
"./package.json": "./package.json"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
"name": "e2e-test-dep-svelte-simple",
"main": "index.js",
"svelte": "index.js",
"files": [
"src",
"index.js"
],
"dependencies": {
"e2e-test-dep-cjs-only": "file:../cjs-only"
},
Expand Down

0 comments on commit 89ea5e8

Please sign in to comment.