chore: update pnpm 8 #618
chore: update pnpm 8 #618
Conversation
|
looks like the file: protocol in for _test_dependencies works differently in pnpm@8 :/ |
|
Ah wait I approved without reading the comments 🙈 |
|
Should we use |
| "pnpm": "^7.13.0", | ||
| "yarn": "forbidden, use pnpm", | ||
| "npm": "forbidden, use pnpm", |
There was a problem hiding this comment.
you can leave this in place if you'd like. you just need to switch ^ to >= which I believe is the thing that's currently stopping me from using this repo
There was a problem hiding this comment.
you can enable corepack locally to ease working with different package manager versions, or switch manually. until the issue with 8 is resolved, 7 must be used.
There was a problem hiding this comment.
added back engines.pnpm and rewriting it for node14 tests. left the other two removed as neither npm nor yarn check it anymore i think.
that action uses curlbashing and it also adds an additional point where pnpm version is set. this setup here uses packageManager as canonical and doesnt require a separate action. ymmv but i very much prefer the current approach |
|
Just FYI, the action also uses |
…s all files needed by tests
No description provided.