Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pnpm 7 or 8 #624

Closed
wants to merge 1 commit into from
Closed

Allow pnpm 7 or 8 #624

wants to merge 1 commit into from

Conversation

benmccann
Copy link
Member

This is a simpler alternative to #618, which would unblock people immediately without needing to address any of the test compatibility issues with pnpm 8 and avoids the CI complication of using different versions of pnpm with different versions of Node

@dominikg
Copy link
Member

As mentioned in another PR, i don't think it is a good idea to allow working on a project with different major versions of a package manager. I've been burned by multiple migrations from npm x to npm y, and pnpm 6 to 7 wasn't a walk in the park either.

The exception for using node14 with pnpm7 is needed because pnpm8 doesn't work with node14 and we still need to run the CI on 14 until we are able to drop it in the next major (probably alongside vite 5 in fall, maybe earlier if a new svelte release mandates it)

@benmccann
Copy link
Member Author

Yeah, pnpm 6 and 7 was terrible. I think they learned from that and made compatibility better with 7 and 8 though. I've got other projects setup this way and haven't hit any issues.

@benmccann
Copy link
Member Author

Ah, I hadn't seen your response in the other thread yet. I guess the test issues in that PR are a fair example of where 7 and 8 differ

@benmccann benmccann closed this Apr 15, 2023
@benmccann benmccann deleted the local-pnpm8 branch April 15, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants