Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Go version matrix strategy for CI workflow #16

Closed
svengreb opened this issue Sep 25, 2020 · 0 comments · Fixed by #17
Closed

Optimize Go version matrix strategy for CI workflow #16

svengreb opened this issue Sep 25, 2020 · 0 comments · Fixed by #17
Labels
context-workflow scope-maintainability scope-performance type-improvement
Milestone
0.3.0

Comments

@svengreb
Copy link
Owner

The CI workflow currently uses a matrix strategy to run the lint-go and test jobs, but this can be improved to make the workflow run faster by avoiding unnecessary steps:

These changes will also help to keep the required GitHub Action run minutes for the account of this repository as small as possible without wasting resources for unnecessary tasks.
@svengreb svengreb added this to the Next milestone Sep 25, 2020
@svengreb svengreb self-assigned this Sep 25, 2020
@svengreb svengreb changed the title Optimize OSGo version matrix strategy for CI workflow Optimize Go version matrix strategy for CI workflow Sep 25, 2020
svengreb added a commit that referenced this issue Sep 25, 2020
@svengreb
Optimize Go version matrix strategy for CI workflow
3b96c22 
Before the CI workflow used a matrix strategy to run the `lint-go` and
`test` jobs, but this was improved to make the workflow run faster by
avoiding unnecessary steps:

- The `lint-go` job has been changed to only run on the currently latest
  stable Go version `1.15.x` [1] only on Linux because `golangci-lint`
  doesn't care about the Go version and OS it runs on but only
  statically checks the source code.
- The `test` job has been changed to only run on the currently latest
  stable Go version `1.15.x` [1].

These changes also help to keep the required GitHub Action run minutes
for the account of this repository as small as possible without wasting
resources for unnecessary tasks.

[1]: https://golang.org/doc/go1.15

GH-16
@svengreb svengreb mentioned this issue Sep 25, 2020
Merged
svengreb added a commit that referenced this issue Sep 25, 2020
@svengreb
Optimize Go version matrix strategy for CI workflow (#17)
bda13d8 
Before the CI workflow used a matrix strategy to run the `lint-go` and
`test` jobs, but this was improved to make the workflow run faster by
avoiding unnecessary steps:

- The `lint-go` job has been changed to only run on the currently latest
  stable Go version `1.15.x` [1] only on Linux because `golangci-lint`
  doesn't care about the Go version and OS it runs on but only
  statically checks the source code.
- The `test` job has been changed to only run on the currently latest
  stable Go version `1.15.x` [1].

These changes also help to keep the required GitHub Action run minutes
for the account of this repository as small as possible without wasting
resources for unnecessary tasks.

[1]: https://golang.org/doc/go1.15

Resolves GH-16
@svengreb svengreb removed their assignment Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-workflow scope-maintainability scope-performance type-improvement
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Optimize Go version matrix strategy for CI workflow svengreb/tmpl-go
1 participant
@svengreb