Disable "errorlint" to prevent false-positive errors #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In GH-21 [1] "golangci-lint" was updated to the currently latest version 1.32.0 [2] which introduced the errorlint [3] that has been enabled for this template repository. As it turns out it causes a lot of false-positives errors for code lines that explicitly do not wrap the error to prevent it become part of the public API. Therefore the linter has been disabled again because the update also introduced the new wrapcheck [4] linter which helps to prevent that errors from external packages are exposed to the public API. [1]: #21 [2]: https://github.com/golangci/golangci-lint/releases/tag/v1.32.0 [3]: https://github.com/polyfloyd/go-errorlint [4]: https://github.com/tomarrell/wrapcheck GH-39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #39